Skip to content

DYN-: DYN 8294 Fix crash when placing node after undo operation using DNA #15842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeusongit merged 1 commit into from
Feb 19, 2025
Merged

DYN-: DYN 8294 Fix crash when placing node after undo operation using DNA #15842

zeusongit merged 1 commit into from
Feb 19, 2025

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Feb 19, 2025 •
edited
Loading

Purpose

This PR handles the exception thrown after a user tries to place a node following an undo operation using NodeAutocomplete feature, the cause was a null object reference.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Fix crash when placing node after undo operation using DNA

Reviewers

@DynamoDS/dynamo

@zeusongit zeusongit added this to the 3.5 milestone Feb 19, 2025
@github-actions github-actions bot changed the title DYN 8294 Fix crash when placing node after undo operation using DNA DYN-: DYN 8294 Fix crash when placing node after undo operation using DNA Feb 19, 2025
github-actions[bot]
github-actions bot reviewed Feb 19, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8294

@QilongTang
Copy link
Contributor

QilongTang commented Feb 19, 2025

I guess these interactions with DNA is not unit testable? Is there a plan to add AGT test?

@zeusongit
Copy link
Contributor Author

zeusongit commented Feb 19, 2025

I guess these interactions with DNA is not unit testable? Is there a plan to add AGT test?

This specific example was an edge case, which only reproduced if a user did Undo operation, while not unit testable, it should be doable with AGT. I will add a task for that.

@zeusongit zeusongit merged commit b32fd43 into DynamoDS:master Feb 19, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QilongTang QilongTang QilongTang approved these changes

@aparajit-pratap aparajit-pratap Awaiting requested review from aparajit-pratap

@reddyashish reddyashish Awaiting requested review from reddyashish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5

Development

Successfully merging this pull request may close these issues.

2 participants

@zeusongit @QilongTang