Skip to content

Conversation

@reddyashish
Copy link
Contributor

Purpose

https://jira.autodesk.com/browse/DYN-8019

OnRequestShowFileDialog event was not being subscribed after clearing the package search text. Also to avoid multiple event bindings, added the event sub in the AddToSearchResults().

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

[DYN-8019] Fix package - install to folder function.

Reviewers

@QilongTang @zeusongit

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8019

@QilongTang QilongTang added this to the 3.5 milestone Feb 13, 2025
@reddyashish reddyashish merged commit b00145d into DynamoDS:master Feb 13, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants