[DYN-7942] Catch exception during undo operation. #15812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7942
UI Smoke TestsTest: success. 11 passed, 0 failed. |
QilongTang
reviewed
Feb 6, 2025
| } | ||
| catch (InvalidOperationException ex) | ||
| { | ||
| Log(ex); |
Contributor
There was a problem hiding this comment.
Is this logging to Dynamo Console?
Contributor
Author
There was a problem hiding this comment.
I think the log(exception) is logged as error to the log file.
QilongTang
approved these changes
Feb 6, 2025
Contributor
|
1 test failed, seems related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-7942
The PopActionGroupFromUndoStack() throws an invalid operation exception when the undo stack is empty. We are not catching it and returning the value directly in PopFromUndoGroup(). So added the try catch for that.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
[DYN-7942] Catch exception during undo operation.
Reviewers
@zeusongit @QilongTang