Bring back search performance improvement #15789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| AnalyticsService.ShutDown(); | ||
|
|
||
| LuceneSearch.LuceneUtilityNodeSearch = null; |
Member
There was a problem hiding this comment.
so what were we leaking? Or rather what were the retention paths? Would make a good tech talk.
Contributor
Author
There was a problem hiding this comment.
LuceneUtilityNodeSearch holds a reference to the DynamoModel.
So the DynamoModel was not being garbage collected because it still had refs.
| foreach (AnnotationModel annotation in Model.Annotations) Model_AnnotationAdded(annotation); | ||
| foreach (ConnectorModel connector in Model.Connectors) Connectors_ConnectorAdded(connector); | ||
|
|
||
| NodeAutoCompleteSearchViewModel = new NodeAutoCompleteSearchViewModel(DynamoViewModel) |
Contributor
Author
There was a problem hiding this comment.
hopefully it does not break serviceMode :)
Looks like the intention was to do not use autocomplete in service mode
mjkkirschner
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Bring back the search bar perf improvements
Passes here https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-Dynamo/job/DynamoBuildscripts/job/master/2968/
Last test to log size:
PID 3552 Finished test: WillNotAddDupWorkspaceDependencyViewExtensionLoadTest with PrivateBytes = 8608387072
(FILL ME IN) This section describes why this PR is here. Usually it would include a reference to the tracking task that it is part or all of the solution for.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of