flush dispatcher after node manipulation fixture #15769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UI Smoke TestsTest: success. 11 passed, 0 failed. |
pinzart90
reviewed
Jan 22, 2025
| public void Exit() | ||
| { | ||
|
|
||
| Dispatcher.CurrentDispatcher.Hooks.OperationPosted -= Hooks_OperationPosted; |
Contributor
There was a problem hiding this comment.
can you try to the handler cleanup after DoEventsLoop ? or did you try and it broke everything ?
pinzart90
approved these changes
Jan 22, 2025
Contributor
pinzart90
left a comment
There was a problem hiding this comment.
Maybe try to run it locally multiple times to make sure this change fixes the crash
Member
Author
|
passed twice merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up to:
#15768
that I want to test in isolation, this PR adds a one time tear down to the node manipulation test fixture that clears the dispatcher and somehow magically avoids the exception we were seeing from helix due to observable collection changes.