Skip to content

DYN-8163, DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character #15762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
johnpierson merged 8 commits into from
Jan 17, 2025
Merged

DYN-8163, DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character #15762

johnpierson merged 8 commits into from
Jan 17, 2025

Conversation

@johnpierson
Copy link
Member

@johnpierson johnpierson commented Jan 17, 2025

Allows for the user to use underscore character in notes again. Also adds the numpad minus key for bullet completion

Purpose

This PR allows the user to add underscore "_" character in notes again. It also adds the ability for the numpad "-" symbol to be used as a bullet item.

Previous interactions:

20250117-noteBullet

Proposed:

20250117-noteBulletFix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Notes in Dynamo allow for underscore characters once again. Additionally, the "-" key on the numpad is used to create bullet items now in notes.

Reviewers

@QilongTang @reddyashish

FYIs

@achintyabhat @avidit

@QilongTang QilongTang added this to the 3.5 milestone Jan 17, 2025
@QilongTang
Copy link
Contributor

QilongTang commented Jan 17, 2025

Thanks @johnpierson We usually put Jira issue number at the beginning of PR title so that internal automation can link the PR to the issue, would you do that when you are aware of the issue number?

@johnpierson
Copy link
Member Author

johnpierson commented Jan 17, 2025 via email

@johnpierson
Copy link
Member Author

johnpierson commented Jan 17, 2025

For multiple JIRA tickets, how would that work?

@avidit avidit changed the title Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character DYN-8163 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character Jan 17, 2025
github-actions[bot]
github-actions bot reviewed Jan 17, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8163

@github-actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@johnpierson johnpierson changed the title DYN-8163 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character DYN-8163, DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character Jan 17, 2025
@johnpierson johnpierson changed the title DYN-8163, DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character Jan 17, 2025
github-actions[bot]
github-actions bot reviewed Jan 17, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8164

@johnpierson johnpierson changed the title DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character DYN-8163, DYN-8164 Modify NoteView.xaml.cs to allow for underscore character and bullets from numpad "-" character Jan 17, 2025
@johnpierson
Copy link
Member Author

johnpierson commented Jan 17, 2025

Ok, I think I managed to get everything correct. Sorry about that @QilongTang

@johnpierson
Copy link
Member Author

johnpierson commented Jan 17, 2025

Cool side note on this, it allows for the user to disallow bullets with shift+enter, like word does

@johnpierson johnpierson merged commit 2c89ba7 into DynamoDS:master Jan 17, 2025
21 of 23 checks passed
@johnpierson johnpierson deleted the johnP_noteBulletModifications branch January 17, 2025 16:57
@QilongTang
Copy link
Contributor

QilongTang commented Jan 17, 2025

Oops, another tip @johnpierson Please wait for all the PR checks to finish before merging. In this case, the Dynamo SelfServe check is pretty important to make sure any new PR does not bring additional regression to master branch.

@johnpierson
Copy link
Member Author

johnpierson commented Jan 17, 2025

oh darnit. sorry about that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QilongTang QilongTang QilongTang approved these changes

@reddyashish reddyashish Awaiting requested review from reddyashish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5

Development

Successfully merging this pull request may close these issues.

2 participants

@johnpierson @QilongTang