Skip to content

[DYN-8026] Fix watch node which has corrupted size. #15755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reddyashish merged 2 commits into from
Jan 14, 2025
Merged

[DYN-8026] Fix watch node which has corrupted size. #15755

reddyashish merged 2 commits into from
Jan 14, 2025

Conversation

@reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Jan 14, 2025 •
edited by QilongTang
Loading

Purpose

Task: https://jira.autodesk.com/browse/DYN-8026

Before:
image

Fixes the case where watch node has a wrong size serialized in the graph.

watch node

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

[DYN-8026] Fix watch node which has corrupted size.

Reviewers

@QilongTang @mjkkirschner

github-actions[bot]
github-actions bot reviewed Jan 14, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8026

@github-actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@mjkkirschner
Copy link
Member

mjkkirschner commented Jan 14, 2025

nice, thanks for fixing this @reddyashish - can you add a test for it?
Could be as simple as testing CustomizeView for the watch node with manually set bad data?

@reddyashish
Copy link
Contributor Author

reddyashish commented Jan 14, 2025

The failing test in the job is a flaky unrelated one: SplashScreen_MultipleCloseMessages. Passes locally.

@reddyashish reddyashish merged commit bf568b0 into DynamoDS:master Jan 14, 2025
25 of 26 checks passed
@QilongTang QilongTang added this to the 3.5 milestone Jan 14, 2025
@QilongTang
Copy link
Contributor

QilongTang commented Jan 14, 2025

Thanks @reddyashish let's demo it next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mjkkirschner mjkkirschner mjkkirschner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5

Development

Successfully merging this pull request may close these issues.

3 participants

@reddyashish @mjkkirschner @QilongTang