Skip to content

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Dec 11, 2024

Purpose

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference to the tracking task that it is part or all of the solution for.

DynamoSandbox_A7Q1Y3GGFp

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • resizing via thumb
  • removes maxwidth if resizing is done and forfeits auto-expand/shrink capabilities
  • now serialized width and height
  • different than the Width and Height parameters of the base class
  • add resizing to the undo/redo stack

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

- resizing via thumb
- removes maxwidth if resizing is done and forfeits auto-expand/shrink capabilities
- resizing via thumb
- removes maxwidth if resizing is done and forfeits auto-expand/shrink capabilities
@github-actions github-actions bot changed the title Dyn 7601] resizable string nodes DYN-: Dyn 7601] resizable string nodes Dec 11, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7601

@github-actions
Copy link

github-actions bot commented Dec 11, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

- once the user resizes a graph, marks the file as needs saving
- added support for undo/redo for the new serialized values
- we need to manually call a command that triggers the undo/redo change
@dnenov dnenov changed the title DYN-: Dyn 7601] resizable string nodes DYN-7601: resizable string nodes Dec 16, 2024
@reddyashish reddyashish marked this pull request as ready for review December 16, 2024 23:46
@reddyashish
Copy link
Contributor

@reddyashish reddyashish merged commit 23bf463 into DynamoDS:master Dec 19, 2024
27 of 28 checks passed
@QilongTang QilongTang added this to the 3.5 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants