DYN-9999 : add asc install path to system path #15717
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-9999
UI Smoke TestsTest: success. 11 passed, 0 failed. |
sm6srw
approved these changes
Dec 10, 2024
Contributor
sm6srw
left a comment
There was a problem hiding this comment.
Thanks, this should also work if the ASC path is overridden.
| } | ||
| catch | ||
| { | ||
| Trace.WriteLine("Failed to update path for ASC component"); |
Member
There was a problem hiding this comment.
does trace make it to the dynamo log?
Contributor
Author
There was a problem hiding this comment.
no, trace does not make it to dynamo log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ASC path is already added by a major host installer in the system path.
So this change is useful only for internal development ( and similar to what Revit does for package builds ).
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@sm6srw