Skip to content

DYN-7833 Update TuneUp #15712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reddyashish merged 2 commits into from
Dec 11, 2024
Merged

DYN-7833 Update TuneUp #15712

reddyashish merged 2 commits into from
Dec 11, 2024

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Dec 6, 2024 •
edited
Loading

Purpose

Update TuneUp in Dynamo built-in package per DynamoDS/TuneUp#86

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

When switching to custom node workspace, Run All button on TuneUp will be disabled

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.5 milestone Dec 6, 2024
github-actions[bot]
github-actions bot reviewed Dec 6, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7833

@github-actions
Copy link

github-actions bot commented Dec 6, 2024 •
edited
Loading

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@reddyashish
Copy link
Contributor

reddyashish commented Dec 11, 2024

@QilongTang pkg.json under the tuneup should be updated too. Is this DynamoDS/TuneUp#86 going to be the only fix for 2.0.1?

@QilongTang
Copy link
Contributor Author

QilongTang commented Dec 11, 2024

@QilongTang pkg.json under the tuneup should be updated too. Is this DynamoDS/TuneUp#86 going to be the only fix for 2.0.1?

Yes, the only fix and done addressing comment.

@reddyashish reddyashish merged commit 956959f into master Dec 11, 2024
21 of 22 checks passed
@reddyashish reddyashish deleted the UpdateTuneUp branch December 11, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@reddyashish reddyashish reddyashish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5

Development

Successfully merging this pull request may close these issues.

3 participants

@QilongTang @reddyashish