DYN-7435 Corrupted Chars ON CHS OS #15699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a Windows 10 OS installed in Chinese Traditional if you open DocumentationBrowser several times for each node in the workspace, the DocumentationBrowser starts to show weird characters and the html layout seems different, this was happening due that the Md2Html.Convert and Md2Html.Sanitize methods were not executed, after my fix now they were executed but was still showing weird characters (due that Md2Html encoding was in Chinese Traditional). Then for fixing this problem I had to encode the info using base64 and decoded when is needed. There was a freeze reported in the Jira task but I was not able to reproduce it after my fix.
fixing bug that was generating a infinite loop
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7435
Contributor
Author
|
This is a GIF showing the behavior BEFORE my fix. |
Contributor
Author
|
This is a GIF showing the behavior AFTER my fix |
QilongTang
approved these changes
Dec 5, 2024
Contributor
|
LGTM, Send this to @sm6srw to also review. |
UI Smoke TestsTest: success. 11 passed, 0 failed. |
Due that FeatureFlags is using CLIWrapper as a Base Class my changes related to decoding base64 data were crashing the FeatureFlags.exe process and several tests were failing. Then I've added a extra default parameter in the GetData method so it will know if the data needs to be decoded or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix for not showing weird characters in DocumentationBrowser in a CHS OS
When using a Windows 10 OS installed in Chinese Traditional if you open DocumentationBrowser several times for each node in the workspace, the DocumentationBrowser starts to show weird characters and the html layout seems different, this was happening due that the Md2Html.Convert and Md2Html.Sanitize methods were not executed, after my fix now they were executed but was still showing weird characters (due that Md2Html encoding was in Chinese Traditional). Then for fixing this problem I had to encode the info using base64 and decoded when is needed.
There was a freeze reported in the Jira task but I was not able to reproduce it after my fix.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Fix for not showing weird characters in DocumentationBrowser in a CHS OS
Reviewers
@QilongTang
FYIs