Skip to content

Conversation

@ivaylo-matov
Copy link
Contributor

Purpose

PR aims to address DYN-7841 which reported a misalignment between the centers of inports and the connector ends when a group is collapsed.

The issue was caused by a mismatch between PortModel.Height (34) and Grid.Height (35) in the related views. This inconsistency was resolved by setting both values to 34.

DYN-7841

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fixed an issue where inports were misaligned with connector ends when a group was collapsed by standardizing port dimensions.

Reviewers

@reddyashish
@QilongTang

FYIs

@dnenov

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7841

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@reddyashish reddyashish merged commit 6af6841 into DynamoDS:master Dec 4, 2024
22 checks passed
@QilongTang QilongTang added this to the 3.5 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants