Skip to content

Conversation

@ivaylo-matov
Copy link
Contributor

Purpose

PR aims to address DYN-6574.

The color contrast logic previously applied to group text now extends to the group controls. When the group background color is dark, the controls will automatically change to a light color.

DYN-6574-Fix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

The color contrast logic previously applied to group text now extends to the group controls. When the group background color is dark, the controls will automatically change to a light color.

Reviewers

@QilongTang
@reddyashish

FYIs

@dnenov

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6574

@ivaylo-matov ivaylo-matov reopened this Nov 22, 2024
@github-actions
Copy link

github-actions bot commented Nov 22, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang added this to the 3.5 milestone Nov 22, 2024
@QilongTang QilongTang merged commit f39eebc into DynamoDS:master Nov 25, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants