[DYN-7839] Wires & Pins: improve snapping tolerance #15683
Conversation
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7839
UI Smoke TestsTest: success. 11 passed, 0 failed. |
|
? |
|
hi @ivaylo-matov Would love more time reviewing this PR, curious about the performance impact of the second connector here. Given this change would affect every connector, would you make some time comparison in bigger graphs? |
|
@achintyabhat, I’ve implemented scaling functionality for the anchor, pin, and watch buttons. The size of these buttons now decreases as you zoom out with a non-linear scaling behavior. At Zoom = 1, the buttons retain their default size, but at smaller scales, the size gradually reduces to half of their original dimensions. IMO keeping the default button size at smaller scales looks odd. With this scaling behavior, the buttons remain comfortably clickable, even at zoom levels where the connector is no longer visible.
@QilongTang, I compared the opening times for Performance-Test.dyn against |
Purpose
PR aims to address DYN-7839.
This update enhances the snapping tolerance for connectors when interacting with the ConnectorAnchor.
A second, invisible connector has been introduced to handle MouseEnter and MouseLeave events. This invisible connector features a dynamic
StrokeThicknessthat adjusts based on the current zoom level:Zoom > 1: The
StrokeThicknessmatches the visible connector's thickness (default: 3).Zoom < 1: The
StrokeThicknessdynamically scales with the zoom factor, ensuring that the actual snapping area on the screen remains consistent regardless of the zoom level.The
StrokeThicknessis doubled at smaller zoom factors to improve the responsiveness.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Improved connector snapping at lower zoom levels for Pin and Watch buttons.
Reviewers
@QilongTang
@reddyashish
FYIs
@dnenov