Skip to content

DYN-7716 Fixing Flaky Tests #15680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 1 commit into from
Nov 22, 2024
Merged

DYN-7716 Fixing Flaky Tests #15680

QilongTang merged 1 commit into from
Nov 22, 2024

Conversation

@RobertGlobant20
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 commented Nov 21, 2024

Purpose

DYN-7716 Fixing Flaky Tests
Fixing flaky tests that sometimes are failing and sometimes are not failing.
There are some tests that sometimes are failing and sometimes are not failing so those test were marked as Category[Failure].
So in this fix I'm removing that Category and make changes to fix the tests and get more info about why are failing.
This is the list of tests failing

  • LuceneSearchTSplineNodesOrderingValidation()
  • NodeSuggestions_OutputPortBuiltInNode_AreCorrect()
  • NodeSuggestions_CanAutoCompleteOnCustomNodesOutPort_WithSpaceInPortName()

I've run the DYN-DevCI_Self_Service job two times without any test failing (also local tests in VS2022 are passing) but I will continue checking if in the jobs there are failing test in this PR

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fixing flaky tests that sometimes are failing and sometimes are not failing.

Reviewers

@QilongTang

FYIs

@RobertGlobant20
Fixing Flaky Tests
370a210 
There are some tests that sometimes are failing and sometimes are not failing so those test were marked as Category[Failure].
So in this fix I'm removing that Category and make changes to fix the test and get more info about why are failing.
github-actions[bot]
github-actions bot reviewed Nov 21, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7716

@QilongTang QilongTang added this to the 3.5 milestone Nov 21, 2024
@github-actions
Copy link

github-actions bot commented Nov 21, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang
Copy link
Contributor

QilongTang commented Nov 21, 2024

@RobertGlobant20 There is one regression reported but not related to the tests you turning on as part of this PR, can you check if that pass locally?

@RobertGlobant20
Copy link
Contributor Author

RobertGlobant20 commented Nov 22, 2024

@QilongTang the test failing is (I think is not related to this change):

[Test]
[Category("FailureDynCore")]
public void FeatureFlagsShouldReturnRealDataAfterCache()

"FailureDynCore" means that will be failing on DynamoCore?

Thanks

@QilongTang
Copy link
Contributor

QilongTang commented Nov 22, 2024

that will be failing on DynamoCore?

Not sure what that means, you will need to check with who added the test. I will approve the PR for now

@QilongTang QilongTang merged commit 9fcf24a into DynamoDS:master Nov 22, 2024
22 checks passed
@RobertGlobant20
Copy link
Contributor Author

RobertGlobant20 commented Nov 22, 2024

that will be failing on DynamoCore?

Not sure what that means, you will need to check with who added the test. I will approve the PR for now

The job passed here:
https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16865/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.5

Development

Successfully merging this pull request may close these issues.

2 participants

@RobertGlobant20 @QilongTang