Skip to content

DYN-7256 dynamo home tab #15541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 2 commits into from
Oct 14, 2024
Merged

DYN-7256 dynamo home tab #15541

QilongTang merged 2 commits into from
Oct 14, 2024

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Oct 11, 2024

Purpose

This PR responds to As a Dynamo user, I want to switch between current workspace and Dynamo home seamlessly https://jira.autodesk.com/browse/DYN-7256

Changes

DynamoSandbox_sBRTeun5YC

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • a new button as part of the tab control
  • 'fake' select/deselect tab items interaction
  • automatic formatting of the .xaml code of DynamoView.xml because of an extension (I hope it's OK)

Reviewers

@QilongTang

FYIs

@reddyashish

dnenov added 2 commits October 11, 2024 16:21
@dnenov
introduce a new 'home' button
18fd33d 
- a new button as part of the tab control
- accidental resorting of the .xaml code of dynamoView.xml because of an extension
@dnenov
select/deselect tab item
107a2fb 
- simulate select/deselect tab item behavior when using the home page button
@github-actions github-actions bot changed the title Dyn 7256 dynamo home tab DYN-: Dyn 7256 dynamo home tab Oct 11, 2024
github-actions[bot]
github-actions bot reviewed Oct 11, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7256

@dnenov dnenov changed the title DYN-: Dyn 7256 dynamo home tab DYN-7256 dynamo home tab Oct 11, 2024
@QilongTang QilongTang added this to the 3.4 milestone Oct 11, 2024
@github-actions
Copy link

github-actions bot commented Oct 11, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang
Copy link
Contributor

QilongTang commented Oct 14, 2024

Rebuilding at https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16546/

@QilongTang QilongTang merged commit 3c536f9 into DynamoDS:master Oct 14, 2024
@avidit avidit mentioned this pull request Oct 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

2 participants

@dnenov @QilongTang