Skip to content

Conversation

@aparajit-pratap
Copy link
Contributor

Purpose

Handle infinity appropriately.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Handle nodes returning Infinity values correctly.

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7493

@github-actions
Copy link

github-actions bot commented Sep 30, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@QilongTang QilongTang added this to the 3.4 milestone Sep 30, 2024
@QilongTang
Copy link
Contributor

hi @aparajit-pratap Looks good but can we add a unit test easily? Thanks!

@aparajit-pratap
Copy link
Contributor Author

hi @aparajit-pratap Looks good but can we add a unit test easily? Thanks!

@QilongTang will do.

@aparajit-pratap aparajit-pratap merged commit 1344dd4 into DynamoDS:master Oct 28, 2024
@aparajit-pratap aparajit-pratap deleted the infinity branch October 28, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants