DYN-7086 Correctly cast package search results to show updated package info #15373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7086
UI Smoke TestsTest: success. 11 passed, 0 failed. |
QilongTang
reviewed
Jul 8, 2024
| { | ||
| return true; | ||
| } | ||
| return false; |
Contributor
There was a problem hiding this comment.
Do we need this if condition? I thought we can just do CachedPackageList.Where(e =>e.Name.Equals(packageName)
Contributor
Author
There was a problem hiding this comment.
Yep, that's what I thought when I looked at it. But I did not add this code, I just reverted this change to its previous state, thinking don't fix something that ain't broke. ;)
QilongTang
approved these changes
Jul 8, 2024
Contributor
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with one question
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This is fixing a regression in the master for package search.
The search results should be cast to
PackageManagerSearchElementViewModelusing the new methodGetSearchElementViewModelto populate it's install status, this will help correctly display the package info in Package manager window.Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo