Skip to content

DYN-7162 Add back missing node help docs and fix cases were not working #15349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 13 commits into from
Jun 26, 2024
Merged

DYN-7162 Add back missing node help docs and fix cases were not working #15349

QilongTang merged 13 commits into from
Jun 26, 2024

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Jun 25, 2024 •
edited
Loading

Purpose

Per Slack conversation, team finished a round of internal checking on nodes missing help content. In this PR, I am adding back missing dyns that I could validate which were missing.

Also fixed image display for the following nodes:

  • DSCore.Math.Random(value1, value2, seed)
  • DSCore.Math.RandomList(amount, value1, value2, seed)
  • DSCore.Math.Abs(number)
  • DynamoUnits.Quantity.ByTypeID

Added copy step for excel sheets in help docs

Node with issue

  • OpenXML nodes, excel sheets will always come with path problem

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Add back missing node help docs so that customer could see in product help

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.3 milestone Jun 25, 2024
github-actions[bot]
github-actions bot reviewed Jun 25, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7162

@github-actions
Copy link

github-actions bot commented Jun 25, 2024 •
edited
Loading

UI Smoke Tests

Test: success. 3 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang changed the title DYN-7162 Add back missing dyn DYN-7162 Add back missing node help docs and fix cases were not working Jun 25, 2024
@twastvedt
Copy link
Contributor

twastvedt commented Jun 26, 2024 •
edited
Loading

FYI: @twastvedt It looks like the dyn file was missing from original PR

Added, @QilongTang !

@QilongTang
Copy link
Contributor Author

QilongTang commented Jun 26, 2024

FYI: @twastvedt It looks like the dyn file was missing from original PR

Added, @QilongTang !

Awesome, thanks!

@QilongTang
Copy link
Contributor Author

QilongTang commented Jun 26, 2024

SelfServe job interrupted, restarted at https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16229/

RobertGlobant20
RobertGlobant20 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

doc/distrib/NodeHelpFiles/DSCore.Math.Random(value1, value2, seed).md
## Example File

![Math.Random2](./DSCore.Math.Random(value1, value2, seed)_img.png)
![Math.Random2](./DSCore.Math.Random%28value1%2C%20value2%2C%20seed%29_img.png)
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you tested this one and is showing the documentation correctly, right?

Copy link
Contributor Author

@QilongTang QilongTang Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I was using the VSCode md preview and it worked after the change

@QilongTang
Copy link
Contributor Author

QilongTang commented Jun 26, 2024

It was passing last night on https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16225/, the CI seems to be down today so merging for now and FYI @sm6srw

@QilongTang QilongTang merged commit 7a58fa7 into master Jun 26, 2024
@QilongTang QilongTang deleted the MissingNodeHelpDyn branch June 26, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@RobertGlobant20 RobertGlobant20 RobertGlobant20 approved these changes

@zeusongit zeusongit Awaiting requested review from zeusongit

@reddyashish reddyashish Awaiting requested review from reddyashish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

4 participants

@QilongTang @twastvedt @RobertGlobant20