Skip to content

Conversation

@zeusongit
Copy link
Contributor

Purpose

The crash occurred when connecting nodes but the port index was out of bounds from the source collection.
The retrieval code is now in a try-catch block for better error handling.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Fix crash when connecting nodes

Reviewers

@DynamoDS/dynamo

@zeusongit zeusongit requested a review from QilongTang June 21, 2024 14:28
@zeusongit zeusongit changed the title Fix crash when connecting nodes DYN-7110 Fix crash when connecting nodes Jun 21, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7110

@QilongTang QilongTang added this to the 3.3 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants