Skip to content

DYN-7111 Enable package search to show results for package authors as the search key #15338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zeusongit merged 3 commits into from
Jun 21, 2024
Merged

DYN-7111 Enable package search to show results for package authors as the search key #15338

zeusongit merged 3 commits into from
Jun 21, 2024

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Jun 20, 2024

Purpose

The PR adds package authors to indexed data, this will enable users to search for packages based on the username of the desired author.

Before - After screenshots for search comparison:

d5
d4
d3
d2
d1

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Enable users to search for packages based on the username of the desired author.

Reviewers

@DynamoDS/dynamo

FYIs

@Amoursol

github-actions[bot]
github-actions bot reviewed Jun 20, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7111

@zeusongit zeusongit added this to the 3.3 milestone Jun 20, 2024
@zeusongit
Copy link
Contributor Author

zeusongit commented Jun 20, 2024

Unrelated test failures

QilongTang
QilongTang reviewed Jun 21, 2024
View reviewed changes
QilongTang
QilongTang reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one question mainly about the function override

@zeusongit
Copy link
Contributor Author

zeusongit commented Jun 21, 2024

Build passed here: https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/16215/

@QilongTang
Copy link
Contributor

QilongTang commented Jun 21, 2024 •
edited
Loading

Any documentation we need to update after this PR? Internal wiki about Lucene?

@zeusongit
Copy link
Contributor Author

zeusongit commented Jun 21, 2024

Any documentation we need to update after this PR? Internal wiki about Lucene?

I was wondering if we have that, since there are a lot of conditions and customizations, I don't think we have any, but maybe @RobertGlobant20 knows?

@zeusongit zeusongit merged commit f893b7a into DynamoDS:master Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QilongTang QilongTang QilongTang approved these changes

@reddyashish reddyashish Awaiting requested review from reddyashish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

2 participants

@zeusongit @QilongTang