Skip to content

[Cherrypick] DYN-7154: missing thumbnail sample files (#15326) #15334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
reddyashish merged 4 commits into from
Jun 20, 2024
Merged

[Cherrypick] DYN-7154: missing thumbnail sample files (#15326) #15334

reddyashish merged 4 commits into from
Jun 20, 2024

Conversation

@reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Jun 20, 2024

Purpose

Cherrypicking #15326 into 3.2.1.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

[Cherrypick] DYN-7154: missing thumbnail sample files (#15326)

Reviewers

@QilongTang

@reddyashish reddyashish added this to the 3.2.1 milestone Jun 20, 2024
github-actions[bot]
github-actions bot reviewed Jun 20, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-7154

reddyashish
reddyashish commented Jun 20, 2024
View reviewed changes
src/DynamoCoreWpf/DynamoCoreWpf.csproj Outdated


<Target Name="NpmRunBuildHomePage" BeforeTargets="BeforeBuild">
<PropertyGroup>
Copy link
Contributor Author

@reddyashish reddyashish Jun 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaron @zeusongit this change is coming #15316 regarding the skip install step but it is only added for this npm target. Is this ok?

Copy link
Contributor Author

@reddyashish reddyashish Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it.

@reddyashish reddyashish merged commit f58b7db into DynamoDS:RC3.2.1_master Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@reddyashish @QilongTang @dnenov