Skip to content

DYN-6993 Add crash protection for window Owner setting #15238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 2 commits into from
May 23, 2024
Merged

DYN-6993 Add crash protection for window Owner setting #15238

QilongTang merged 2 commits into from
May 23, 2024

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented May 22, 2024

Purpose

Per https://jira.autodesk.com/browse/DYN-6993, add crash protection to DynamoMessageBox display code during window owner assignment.

Here is the crash callstack

presentationframework!_NA_::System.Windows.Window.set_Owner(System.Windows.Window)
dynamocorewpf!_NA_::Dynamo.UI.Prompts.DynamoMessageBox.Show(System.Windows.Window, System.String, System.String, System.Windows.MessageBoxButton, System.Windows.MessageBoxImage)
dynamocorewpf!_NA_::Dynamo.Wpf.Utilities.MessageBoxService+DefaultMessageBox.Show(System.Windows.Window, System.String, System.String, System.Windows.MessageBoxButton, System.Windows.MessageBoxImage)
dynamocorewpf!_NA_::Dynamo.Wpf.Utilities.MessageBoxService.Show(System.Windows.Window, System.String, System.String, System.Windows.MessageBoxButton, System.Windows.MessageBoxImage)
dynamocorewpf!_NA_::Dynamo.Controls.DynamoView.DynamoViewModelRequestUserSaveWorkflow(System.Object, Dynamo.ViewModels.WorkspaceSaveEventArgs)
dynamocorewpf!_NA_::Dynamo.ViewModels.DynamoViewModel.OnRequestUserSaveWorkflow(System.Object, Dynamo.ViewModels.WorkspaceSaveEventArgs)
dynamocorewpf!_NA_::Dynamo.ViewModels.DynamoViewModel.AskUserToSaveWorkspacesOrCancel(Boolean)
dynamocorewpf!_NA_::Dynamo.ViewModels.DynamoViewModel.PerformShutdownSequence(ShutdownParams)
dynamocorewpf!_NA_::Dynamo.Controls.DynamoView.PerformShutdownSequenceOnViewModel()
dynamocorewpf!_NA_::Dynamo.Controls.DynamoView.WindowClosed(System.Object, System.EventArgs)
presentationframework!_NA_::System.Windows.Window.WmDestroy()

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Add crash protection to DynamoMessageBox display code during window owner assignment.

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 3.2 milestone May 22, 2024
github-actions[bot]
github-actions bot reviewed May 22, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6993

@github-actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang merged commit 2a1c187 into master May 23, 2024
@QilongTang QilongTang deleted the WindowOwnerCrash branch May 23, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@avidit avidit avidit approved these changes

@reddyashish reddyashish reddyashish approved these changes

@zeusongit zeusongit Awaiting requested review from zeusongit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.2

Development

Successfully merging this pull request may close these issues.

4 participants

@QilongTang @avidit @reddyashish