Skip to content

DYN-6651 Updating IssueTypePredicter #15199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 2 commits into from
May 13, 2024
Merged

DYN-6651 Updating IssueTypePredicter #15199

QilongTang merged 2 commits into from
May 13, 2024

Conversation

@RobertGlobant20
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 commented May 7, 2024

Purpose

Updating IssueTypePredicter workflow to use .NET 8
The next PR needs to be merged first: DynamoDS/IssuesTypePredicter#2

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Updating IssueTypePredicter workflow to use .NET 8

Reviewers

@QilongTang @reddyashish

FYIs

@RobertGlobant20
DYN-6651 Updating IssueTypePredicter
4a95328 
Updating IssueTypePredicter workflow to use .NET 8
github-actions[bot]
github-actions bot reviewed May 7, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-6651

@github-actions
Copy link

github-actions bot commented May 7, 2024 •
edited
Loading

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@reddyashish
Copy link
Contributor

reddyashish commented May 9, 2024 •
edited
Loading

[ContainsEmptyListOrNullTest] is failing here. So i think you did not pull in the changes from #15190 to fix it?.

@QilongTang
Copy link
Contributor

QilongTang commented May 13, 2024

[ContainsEmptyListOrNullTest] is failing here. So i think you did not pull in the changes from #15190 to fix it?.

Thanks @reddyashish, yeah should be fine to proceed since this fork is behind master most likely

@QilongTang QilongTang merged commit e3e797f into DynamoDS:master May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QilongTang QilongTang QilongTang approved these changes

@reddyashish reddyashish Awaiting requested review from reddyashish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RobertGlobant20 @reddyashish @QilongTang