Skip to content

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Mar 25, 2024

Purpose

This PR cherry-pick the following PRs:

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

@DynamoDS/dynamo

zeusongit and others added 6 commits March 24, 2024 23:38
…13413)

* add deprecated label

* update extension

* sync package manger and package view displays

* finishes

* set horizontal offset

* update HD profile icon

* Update PackageDetailsViewModel.cs

* add comment

* conflicts fix

* Update PackageDetailItem.cs

* Revert "conflicts fix"

This reverts commit 2e60462.

* conflict fix2
* Embedded Artifakt Element as base64

- to ensure the DocumentationBrowser always loads with the correct font, the Artifakt Element font is now included in the css style sheet as base64

* Refactored font resource

- now substitutes an embedded resource containing the font style and converts to base64 before rendering the html page

* Revert unnecessary changes

* FontFace Css rule reintroduced

- brought back a fontface css rule to be whitelisted by the Md2HtmlSanitizer
- all DocumentationBrowserExtension tests passing
* read scientific notation

* remove unecessary reference

* Fix for situation with formulas and add unit tests for scientific notation
* Fix String display

* Adding Unit test

* Checking Formula
* Fixing Ghost warning

* Keeping the Warning Color for the new state

* Adding the Unit test

* Revert "Keeping the Warning Color for the new state"

This reverts commit 40e9643.

* Revert "Fixing Ghost warning"

This reverts commit 04c14c1.

* Updates, Implementation and Test
@QilongTang QilongTang added this to the 2.16.3 milestone Mar 26, 2024
reddyashish and others added 8 commits March 25, 2024 21:17
* Handle null values in watch node/preview bubble

* Add test

* Update WatchNodeTests.cs
* DYN-6073 Civil3D Packages Guide Crashing

It was crashing due that the user tried to close the Step 4 clicking the PackageSearch window and the Popup is not closed but seems that is already disposed.

* DYN-6073 Civil3D Package Tour Crashing

This change is disabling the close button in the PackageManagerSearch window when running the Packages tour, when passing to the next Step the button is enabled again (unless the next step also requires to disable the button). I've added a new icon image that will be shown when the close button is disabled.
In this way we will be preventing the crash when the user try to close the Packages tour by closing the PackageManagerSearch window

* DYN-6073 Civil3D Package Tour Crashing

This fix will solve the problem of the packages guide crashing when clicking the Library (package installed) for passing from Step8 to Step9.
…hen a custom node is created (#14220)

* Fix note in group in customnode

* add test

* merge test from other PR
* Make sure close the Toast notification when Dynamo closes

* Removing extra file

* Removing extra file

* Relocate the responsibility about the toast notification to the DynamoViewModel

* removing unnecessary using

* take advantage of already implementation to apply minimal changes

* Moving the code to a proper place

---------

Co-authored-by: Jesus Alfredo Alviño <jesus.alfredo.alvino@autodesk.com>
@QilongTang QilongTang marked this pull request as ready for review March 26, 2024 02:06
@QilongTang QilongTang changed the title WIP 2.16.3 CherryPicks 2.16.3 CherryPicks Morpheus Mar 26, 2024
@QilongTang
Copy link
Contributor Author

QilongTang commented Mar 26, 2024

The EngOps build failed for ASM libG diff on CI machine. The PR validation is expected to fail as well.

@QilongTang QilongTang merged commit 0380b5b into RC2.16.3_master Mar 26, 2024
@QilongTang QilongTang deleted the CherryPick branch March 26, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants