Skip to content

Conversation

@ivaylo-matov
Copy link
Contributor

@ivaylo-matov ivaylo-matov commented Mar 11, 2024

Purpose

Small PR that adds related Connector Pins to selection when user uses Tab key to select neighboring nodes.

DYN-5149-fix

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

When selecting a node and hitting "tab" it automatically adds the connected nodes to the selection. This is super handy for moving groups of nodes around. The selection will now include not only the next connected node, but all pins of the connectors at the same time.

Reviewers

@dnenov
@reddyashish

FYIs

@Amoursol

Pins included in selection
@ivaylo-matov ivaylo-matov marked this pull request as ready for review March 11, 2024 11:08
@github-actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@ivaylo-matov ivaylo-matov changed the title [DynamoDS/Dynamo] DYN-5149: Pins included in selection DYN-5149: Pins included in selection Mar 11, 2024
@QilongTang QilongTang added this to the 3.1 milestone Mar 11, 2024
@mjkkirschner
Copy link
Member

Tests seem like they would be straight forward to add to this? When the command is invoked ensure the selection is correct?

@QilongTang
Copy link
Contributor

Thanks @mjkkirschner , @ivaylo-matov Would you add a unit test for this chang?

@ivaylo-matov
Copy link
Contributor Author

@QilongTang Sure, will do.

@Amoursol
Copy link
Contributor

@ivaylo-matov for histories sake, can you please create a super quick GIF showing this behavior in action and put it into this PR?

@ivaylo-matov
Copy link
Contributor Author

@Amoursol, all done! I'll make sure to include gifs from now on.

@Amoursol
Copy link
Contributor

@Amoursol, all done! I'll make sure to include gifs from now on.

Brilliant, and thank you very much. This helps a lot :D So yes please to every PR having them if they can be there.

now includes working unit test, thanks to @dnenov
unit test working thanks to dnenov
@QilongTang
Copy link
Contributor

This is in conflict with #15091? Closing this one in favor of the other

@QilongTang QilongTang closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants