-
Notifications
You must be signed in to change notification settings - Fork 668
DYN-5149: Pins included in selection #15007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-5149: Pins included in selection #15007
Conversation
Pins included in selection
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
Tests seem like they would be straight forward to add to this? When the command is invoked ensure the selection is correct? |
|
Thanks @mjkkirschner , @ivaylo-matov Would you add a unit test for this chang? |
|
@QilongTang Sure, will do. |
|
@ivaylo-matov for histories sake, can you please create a super quick GIF showing this behavior in action and put it into this PR? |
|
@Amoursol, all done! I'll make sure to include gifs from now on. |
Brilliant, and thank you very much. This helps a lot :D So yes please to every PR having them if they can be there. |
now includes working unit test, thanks to @dnenov
unit test working thanks to dnenov
|
This is in conflict with #15091? Closing this one in favor of the other |
Purpose
Small PR that adds related Connector Pins to selection when user uses Tab key to select neighboring nodes.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
When selecting a node and hitting "tab" it automatically adds the connected nodes to the selection. This is super handy for moving groups of nodes around. The selection will now include not only the next connected node, but all pins of the connectors at the same time.
Reviewers
@dnenov
@reddyashish
FYIs
@Amoursol