Skip to content

Conversation

@zeusongit
Copy link
Contributor

Purpose

Cherrypick for [DYN-6455] Add warning text to selection node's initial warning (#14833)

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

@DynamoDS/dynamo

…ynamoDS#14829)

* Fix PostDiff job

* Update NodeAutoCompleteSearchViewModel.cs
…moDS#14833)

* Fix PostDiff job

* Update Selection.cs

* made the warning persistent and then add removal code
@zeusongit zeusongit requested a review from QilongTang January 17, 2024 15:54
@QilongTang QilongTang added this to the 3.0.2 milestone Jan 17, 2024
@QilongTang
Copy link
Contributor

I restarted the PR check for this one at https://master-5.jenkins.autodesk.com/job/Dynamo/job/DynamoSelfServe/job/pullRequestValidation/13743/

@QilongTang
Copy link
Contributor

The restarted PR check failed again for unknown reason... Given this change has been validated on master branch with master build post already, merging..

@QilongTang QilongTang merged commit d4fd6d6 into DynamoDS:RC3.0.2_master Jan 17, 2024
@zeusongit
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants