Skip to content

Conversation

@zeusongit
Copy link
Contributor

Purpose

[DYN-6539]

Message of reset updated from
Your changes will be lost if you navigate away from the package upload screen. to
Your changes will be lost if you proceed.
since the user is not navigating away.

Screenshot 2024-01-16 at 4 22 30 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@avidit @QilongTang

@QilongTang QilongTang added this to the 3.1 milestone Jan 16, 2024
@QilongTang
Copy link
Contributor

looks like you have more changes included in this PR, overlapping the other one?

@zeusongit
Copy link
Contributor Author

No, the other change is supposed to be there, I did merge it before, but somehow it does not reflect even after I merge upstream master.

@github-actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang merged commit 685057f into DynamoDS:master Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants