Skip to content

[Fix-2] Fix Graphic Scale Units dropdown localization #14810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 30 commits into from
Jan 8, 2024
Merged

[Fix-2] Fix Graphic Scale Units dropdown localization #14810

QilongTang merged 30 commits into from
Jan 8, 2024

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Jan 4, 2024 •
edited
Loading

Purpose

When a new locale is selected the dropdown was blank as it was not able to match the selected value to the new localized menu items.

Screenshot 2024-01-04 at 1 57 11 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Fix-2 Fix Graphic Scale Units dropdown localization

Reviewers

@avidit

zeusongit added 28 commits August 11, 2023 10:14
@zeusongit
Fix PostDiff job
56ba101
@zeusongit
Merge branch 'master' of https://github.com/zeusongit/Dynamo
dc250de
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
1fecd29
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
90a6c41
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
64c202b
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
d6ac751
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
255feeb
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
4e55f7f
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
1886669
@zeusongit
Merge branch 'master' of https://github.com/zeusongit/Dynamo
8ac6b74
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
41c461c
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
f9cf237
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
a0adaef
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
2ab3d49
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
558df01
@zeusongit
Merge branch 'master' of https://github.com/zeusongit/Dynamo
efdb82b
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
9b712f2
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
7c2dc1e
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
83bcb52
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
30b861d
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
71d23c2
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
cd1c4f9
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
0cae237
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
d9d38c8
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
ecebcda
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
a53e033
@zeusongit
Merge branch 'master' of https://github.com/DynamoDS/Dynamo
764342d
@zeusongit
Update PreferencesViewModel.cs
9b8b24b
@zeusongit zeusongit requested review from QilongTang and avidit January 4, 2024 18:55
@zeusongit zeusongit marked this pull request as ready for review January 4, 2024 18:56
@zeusongit zeusongit changed the title Fix-#2 Fix Graphic Scale Units dropdown localization Fix-2 Fix Graphic Scale Units dropdown localization Jan 4, 2024
@zeusongit zeusongit changed the title Fix-2 Fix Graphic Scale Units dropdown localization [Fix-2] Fix Graphic Scale Units dropdown localization Jan 4, 2024
@github-actions
Copy link

github-actions bot commented Jan 4, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions
Copy link

github-actions bot commented Jan 4, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions
Copy link

github-actions bot commented Jan 4, 2024

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang added this to the 3.0.1 milestone Jan 4, 2024
@zeusongit zeusongit mentioned this pull request Jan 5, 2024
Merged
9 tasks
@QilongTang
Copy link
Contributor

QilongTang commented Jan 8, 2024

Validated in 3.0.1 build

@QilongTang QilongTang merged commit dc38712 into DynamoDS:master Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avidit avidit avidit approved these changes

@QilongTang QilongTang Awaiting requested review from QilongTang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@zeusongit @QilongTang @avidit