Skip to content

Cherry Pick CP DYN-6489 Dynamo Zoom Extents behavior has changed (#14674) #14757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 1 commit into from
Dec 14, 2023
Merged

Cherry Pick CP DYN-6489 Dynamo Zoom Extents behavior has changed (#14674) #14757

QilongTang merged 1 commit into from
Dec 14, 2023

Conversation

@saintentropy
Copy link
Contributor

@saintentropy saintentropy commented Dec 14, 2023

Purpose

CP DYN-6489 Dynamo Zoom Extents behavior has changed #14674

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Zoom Extents for the background preview is now more accurate and predictable regardless of the size of the Dynamo application window.

Reviewers

@QilongTang

FYIs

@mjkkirschner

@saintentropy @mjkkirschner
DYN-6489 Dynamo Zoom Extents behavior has changed (#14674)
564e7f7 
* Adopt updated helix ZoomExtents algorithm

* use Helix native bounds implementation

* Why was this ever this way

* changes made

* handle zoom for ortho

* review comments

---------

Co-authored-by: Craig Long <craig.long@autodesk.com>
Co-authored-by: mjk.kirschner <mjk.kirschner@gmail.com>
(cherry picked from commit 6d50740)
@saintentropy saintentropy changed the title Cherry Pick CP DYN-6489 Dynamo Zoom Extents behavior has changed (14674) Cherry Pick CP DYN-6489 Dynamo Zoom Extents behavior has changed (#14674) Dec 14, 2023
@saintentropy saintentropy changed the base branch from master to RC3.0.0_master December 14, 2023 03:19
@github-actions
Copy link

github-actions bot commented Dec 14, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@github-actions
Copy link

github-actions bot commented Dec 14, 2023

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@QilongTang QilongTang merged commit 4ee2256 into RC3.0.0_master Dec 14, 2023
@QilongTang QilongTang deleted the CPZoomExtents branch December 14, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@saintentropy @QilongTang