Skip to content

Conversation

@Enzo707
Copy link
Contributor

@Enzo707 Enzo707 commented Dec 11, 2023

Screen Recording 2023-12-11 at 11 10 54

Purpose

This PR implements a fix that re-enable the dismiss notifications panel behaviour by clicking the bell icon.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Reviewers

@QilongTang

FYIs

@avidit

@github-actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@github-actions
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net6.0

@Enzo707 Enzo707 requested a review from QilongTang December 12, 2023 14:10
@QilongTang QilongTang merged commit dffb36a into DynamoDS:master Dec 12, 2023
@QilongTang QilongTang added this to the 3.1 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants