Skip to content

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Nov 2, 2023

Purpose

A small PR testing the DateToPackageLabelConverterTest converter. According to the converter description:

Used to determine the text which appears next to a package when it's either

  • brand new or has been recently updated.
  • If the package was updated in the last 30 days it says 'Updated'.
  • If the package is brand new (only has 1 version) and is less than 30 days it says 'New'.

We are asserting that behavior.

This PR cherry-picks and updates some of the changes from #14506. The old one will be closed in favor of multiple smaller PRs.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • converter test added

Reviewers

@mjkkirschner
@reddyashish

FYIs

@Amoursol

@dnenov dnenov mentioned this pull request Nov 2, 2023
9 tasks
@reddyashish reddyashish added this to the 3.0 milestone Nov 2, 2023
@QilongTang QilongTang merged commit d6b1f39 into DynamoDS:master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants