Skip to content

Conversation

@dnenov
Copy link
Collaborator

@dnenov dnenov commented Oct 30, 2023

Purpose

The default null return when fetching user votes was causing Dyanmo initialization to freeze due to an unhandled null value exception. This is a small fix to this bug.

Thank you @saintentropy for raising this one up.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • bug fix causing users with no votes to not be able to start Dynamo because of an unhandled null exception

Reviewers

@saintentropy
@reddyashish

FYIs

@Amoursol

- bug fix causing users with no votes to not be able to start Dynamo because of unhandled null exception
@reddyashish reddyashish added this to the 3.0 milestone Oct 30, 2023
@QilongTang QilongTang merged commit f665018 into DynamoDS:master Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants