Skip to content

DYN-6067 Low Confidence Section Visibility Correction #14518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 1 commit into from
Oct 25, 2023
Merged

DYN-6067 Low Confidence Section Visibility Correction #14518

QilongTang merged 1 commit into from
Oct 25, 2023

Conversation

@QilongTang
Copy link
Contributor

@QilongTang QilongTang commented Oct 25, 2023

Purpose

A follow-up of #14497 to make sure the low confidence section only appears under ML recommendation mode. Pretty simple fix.

image

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Make sure the low confidence section only appears under ML recommendation mode

Reviewers

@DynamoDS/dynamo

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang marked this pull request as ready for review October 25, 2023 05:08
@QilongTang QilongTang added this to the 3.0 milestone Oct 25, 2023
@QilongTang QilongTang changed the title Low Confidence Section Visibility Correction DYN-6067 Low Confidence Section Visibility Correction Oct 25, 2023
@QilongTang QilongTang merged commit 3335952 into master Oct 25, 2023
@QilongTang QilongTang deleted the LowConfidenceVisibility branch October 25, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avidit avidit avidit approved these changes

@reddyashish reddyashish reddyashish approved these changes

@zeusongit zeusongit Awaiting requested review from zeusongit

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@QilongTang @avidit @reddyashish