Skip to content

Conversation

@saintentropy
Copy link
Contributor

Purpose

For the rare case of Node Warnings that are a combination of multiple runtime and build warnings the content can be truncated when the message text is processed to remove help link text.

This change maintains the contents of the full message and format the view for clarity.

Before (Truncated message):
Screenshot 2023-10-23 at 7 48 52 PM

After (Full message):
Screenshot 2023-10-23 at 7 25 49 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Dynamo no longer truncates the rare case of Node Warnings that are a combination of multiple runtime and build warnings.

Reviewers

@mjkkirschner

FYIs

@LongNguyenP @QilongTang

@mjkkirschner
Copy link
Member

LGTM - would be nice to have a test that asserts your example returns the text you expect or is over a certain length or something.

@QilongTang QilongTang added this to the 3.0 milestone Oct 24, 2023
@saintentropy
Copy link
Contributor Author

@mjkkirschner agree on the test. I will add it as soon as the Remember node merges :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants