Skip to content

DYN-6263 Revert avalonedit version #14430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aparajit-pratap merged 2 commits into from
Sep 21, 2023
Merged

DYN-6263 Revert avalonedit version #14430

aparajit-pratap merged 2 commits into from
Sep 21, 2023

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Sep 21, 2023 •
edited
Loading

Purpose

DYN-6263: Revert avalonedit version

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@github-actions
Copy link

github-actions bot commented Sep 21, 2023 •
edited
Loading

⚠️ [run-bin-diff] - Files Added/Deleted::73 new file(s) have been added and 154 file(s) have been deleted!
⚠️ [run-bin-diff-net60-windows] - Files Added/Deleted::15 new file(s) have been added and 32 file(s) have been deleted!
(Updated: 2023-09-21-17:09:24)

@QilongTang QilongTang added this to the 2.19.2 milestone Sep 21, 2023
@QilongTang
Copy link
Contributor

QilongTang commented Sep 21, 2023

Would you check our internal dependency spread sheet and make sure the version there is correct as well? Appreciate it

@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented Sep 21, 2023

Would you check our internal dependency spread sheet and make sure the version there is correct as well? Appreciate it

Done.

@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented Sep 21, 2023

@sm6srw will DynamoSelfServe run as a PR check against this branch?

@QilongTang
Copy link
Contributor

QilongTang commented Sep 21, 2023

@sm6srw will DynamoSelfServe run as a PR check against this branch?

It will, just these days, the delay is insane sometimes :)

@avidit avidit changed the title Revert avalonedit version DYN-6263 Revert avalonedit version Sep 21, 2023
@aparajit-pratap aparajit-pratap merged commit dc70dfa into DynamoDS:RC2.19.2_master Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

@mjkkirschner mjkkirschner Awaiting requested review from mjkkirschner

@sm6srw sm6srw Awaiting requested review from sm6srw

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.19.2

Development

Successfully merging this pull request may close these issues.

2 participants

@aparajit-pratap @QilongTang