Skip to content

Conversation

@jesusalvino
Copy link
Contributor

Purpose

Cherry Pick the commit 8bb226c from the 2.19 branch that add a unit test to the task https://jira.autodesk.com/browse/DYN-6130

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Reviewers

@QilongTang

* Adding the Unit Test TestToastNotificationClosingBehavior

* Simplifying changes

* Removing unnecessary summary

* Reusing local values instead of harcoding

---------

Co-authored-by: Jesus Alfredo Alviño <jesus.alfredo.alvino@autodesk.com>
@QilongTang QilongTang merged commit 96e41f8 into DynamoDS:master Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants