Skip to content

Cherrypicking lucene unit testing #14257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 2 commits into from
Aug 15, 2023
Merged

Cherrypicking lucene unit testing #14257

QilongTang merged 2 commits into from
Aug 15, 2023

Conversation

@reddyashish
Copy link
Contributor

@reddyashish reddyashish commented Aug 14, 2023

Purpose

Cherrypicking Lucene unit testing into 2.19 #14214
and #14253 as followup to fix the library.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Cherrypicking lucene unit testing

Reviewers

@QilongTang

reddyashish and others added 2 commits August 14, 2023 22:09
@reddyashish
DYN-6094 Lucene unit testing (DynamoDS#14214)
fcd1dd4 
* Lucene unit testing

* test updates

* Update LuceneSearchUtility.cs

* Update NodeAutoCompleteSearchViewModel.cs

* Update NodeAutoCompleteSearchViewModel.cs

* Test updates

(cherry picked from commit 780f854)
@pinzart90 @pinzart @reddyashish
Update SearchResultDataProvider.cs (DynamoDS#14253)
deedee6 
Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
(cherry picked from commit aaf6a4e)
@reddyashish
Copy link
Contributor Author

reddyashish commented Aug 14, 2023

@QilongTang Tested that library is loading fine after these changes.

@QilongTang QilongTang added this to the 2.19.0 milestone Aug 14, 2023
@QilongTang
Copy link
Contributor

QilongTang commented Aug 15, 2023

Are these regressions expected? @reddyashish Maybe some diff between 2.19 branch and master?

@QilongTang QilongTang merged commit 2d35bb1 into DynamoDS:RC2.19.0_master Aug 15, 2023
@reddyashish
Copy link
Contributor Author

reddyashish commented Aug 15, 2023

@QilongTang The WPFVisualization tests failing doesn't look related to these changes and Mike mentioned that they are failing due to other changes. https://autodesk.slack.com/archives/C1866AFQB/p1692046172475029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.19.0

Development

Successfully merging this pull request may close these issues.

3 participants

@reddyashish @QilongTang @pinzart90