Skip to content

DYN-6036: Set dropdown IsModified outside WPF #14122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 1 commit into from
Jul 5, 2023
Merged

DYN-6036: Set dropdown IsModified outside WPF #14122

QilongTang merged 1 commit into from
Jul 5, 2023

Conversation

@twastvedt
Copy link
Contributor

@twastvedt twastvedt commented Jun 30, 2023 •
edited
Loading

Please Note:

  1. Before submitting the PR, please review How to Contribute to Dynamo
  2. Dynamo Team will meet 1x a month to review PRs found on Github (Issues will be handled separately)
  3. PRs will be reviewed from oldest to newest
  4. If a reviewed PR requires changes by the owner, the owner of the PR has 30 days to respond. If the PR has seen no activity by the next session, it will be either closed by the team or depending on its utility will be taken over by someone on the team
  5. PRs should use either Dynamo's default PR template or one of these other template options in order to be considered for review.
  6. PRs that do not have one of the Dynamo PR templates completely filled out with all declarations satisfied will not be reviewed by the Dynamo team.
  7. PRs made to the DynamoRevit repo will need to be cherry-picked into all the DynamoRevit Release branches that Dynamo supports. Contributors will be responsible for cherry-picking their reviewed commits to the other branches after a LGTM label is added to the PR.

Purpose

DYN-6036

Moves dropdowns' OnNodeModified call outside WPF so that it is also run in ui-less mode.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fix a bug where dropdown nodes were not marked as modified when the node's value was changed programatically while running in ui-less mode.

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@QilongTang QilongTang added this to the 2.19.0 milestone Jun 30, 2023
@QilongTang
Copy link
Contributor

QilongTang commented Jun 30, 2023

Looks safe but just curious have you tested in Revit that it does not affect Dropdown nodes?

@twastvedt
Copy link
Contributor Author

twastvedt commented Jun 30, 2023

@QilongTang Just did, Revit dropdowns look to be working as usual.

mjkkirschner
mjkkirschner reviewed Jun 30, 2023
View reviewed changes
test/DynamoCoreTests/Nodes/CustomDropdownTests.cs
LoadSamplesPackage();
RunDropdownGraph();

NodeModel node = CurrentDynamoModel.CurrentWorkspace.Nodes.FirstOrDefault();
Copy link
Member

@mjkkirschner mjkkirschner Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there only one node in this graph?

Copy link
Contributor Author

@twastvedt twastvedt Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nodes. The first is the dropdown, the second is a watch node.

@mjkkirschner
Copy link
Member

mjkkirschner commented Jun 30, 2023 •
edited
Loading

I am curious did you just run into this or is it a longstanding known issue?

@twastvedt
Copy link
Contributor Author

twastvedt commented Jun 30, 2023

I am curious did you just run into this or is it a longstanding known issue?

Just ran into it, though I think it's been around, undiscovered. When Player runs graphs it always forces Dynamo to reload the graph - a design decision. In testing the new player we forgot about that detail and were running without reloading, seeing dropdowns not rerunning their AST when the value was changed.

@QilongTang QilongTang merged commit f7e09d1 into master Jul 5, 2023
@QilongTang QilongTang deleted the DYN-6036-dropdown-modified branch July 5, 2023 04:42
@twastvedt twastvedt mentioned this pull request Nov 29, 2023
Merged
9 tasks
@saintentropy saintentropy mentioned this pull request Mar 14, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjkkirschner mjkkirschner mjkkirschner approved these changes

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.19.0

Development

Successfully merging this pull request may close these issues.

4 participants

@twastvedt @QilongTang @mjkkirschner