Lucene search in package manager #14098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QilongTang
reviewed
Jun 21, 2023
QilongTang
reviewed
Jun 21, 2023
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Jun 21, 2023
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Show resolved
Hide resolved
QilongTang
reviewed
Jun 21, 2023
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Jun 25, 2023
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Jun 25, 2023
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Jun 25, 2023
Contributor
QilongTang
left a comment
There was a problem hiding this comment.
Some more comments then LGTM
RobertGlobant20
approved these changes
Jun 26, 2023
Contributor
RobertGlobant20
left a comment
There was a problem hiding this comment.
LGTM with one comment
src/DynamoCoreWpf/ViewModels/PackageManager/PackageManagerSearchViewModel.cs
Outdated
Show resolved
Hide resolved
QilongTang
reviewed
Jun 27, 2023
| internal void AddZeroTouchNodesToSearch(IEnumerable<FunctionGroup> functionGroups) | ||
| { | ||
| var iDoc = InitializeIndexDocument(); | ||
| var iDoc = LuceneSearchUtility.InitializeIndexDocumentForNodes(); |
Contributor
There was a problem hiding this comment.
@RobertGlobant20 Not related to this task but maybe yours, can we explore way to append search info to existing index files? This would work either for new nodes or packages
Contributor
There was a problem hiding this comment.
@QilongTang yes, right now I'm exploring how to append search info for the task of showing node-packages installed in the package search results.
QilongTang
reviewed
Jun 27, 2023
QilongTang
reviewed
Jun 27, 2023
Contributor
QilongTang
left a comment
There was a problem hiding this comment.
LGTM with comments. Thanks for the code re-arrange
Contributor
Author
QilongTang
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Lucene search in package manager.
The package fields that are searched for are Name, Description, Search Keywords, Hosts.
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Lucene search in package manager
Reviewers
@QilongTang @RobertGlobant20