Skip to content

Conversation

@reddyashish
Copy link
Contributor

Purpose

For the crash reported here https://autodesk.slack.com/archives/C01C2AGPSG2/p1684856549984199 by Aaron, this should fix it.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fix python editor crash inside custom node.

Reviewers

@QilongTang @avidit

@QilongTang
Copy link
Contributor

Is it worth adding a unit test or test complete case? @avidit

@QilongTang QilongTang added this to the 2.19.0 milestone May 23, 2023
@reddyashish reddyashish merged commit ce70b50 into DynamoDS:master May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants