Skip to content

Cherry-picking into 2.18.1 #14002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 2 commits into from
May 18, 2023
Merged

Cherry-picking into 2.18.1 #14002

QilongTang merged 2 commits into from
May 18, 2023

Conversation

@reddyashish
Copy link
Contributor

@reddyashish reddyashish commented May 17, 2023

Purpose

A couple of minor changes regressed in 2.18 version and including them as part of 2.18.1 hotfix.

  1. DYN-5657 - Insert shortcut change #13995
  2. class keyword designscript align #13998

One more crash fix related to the python script editor will be coming in from @dnenov.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

@QilongTang @Amoursol

dnenov added 2 commits May 17, 2023 16:24
@dnenov @reddyashish
Insert shortcut change (DynamoDS#13995)
a5597d5 
- changed the shortcut combination for the Insert command
- now uses Ctrl + Shift + I instead of Ctrl + I

(cherry picked from commit 1c599af)
@dnenov @reddyashish
class keyword designscript align (DynamoDS#13998)
50550a7 
- aligned class keyword color to python

(cherry picked from commit dcea09c)
@reddyashish reddyashish added this to the 2.18.1 milestone May 17, 2023
@QilongTang QilongTang merged commit 6275224 into DynamoDS:RC2.18.1_master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.18.1

Development

Successfully merging this pull request may close these issues.

3 participants

@reddyashish @QilongTang @dnenov