Skip to content

[Cherry-pick] Fix Civil3D hostname to fix psuedo warning for package users (#13910) #13935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 1 commit into from
Apr 25, 2023
Merged

[Cherry-pick] Fix Civil3D hostname to fix psuedo warning for package users (#13910) #13935

QilongTang merged 1 commit into from
Apr 25, 2023

Conversation

@zeusongit
Copy link
Contributor

@zeusongit zeusongit commented Apr 25, 2023

Purpose

cherry pick #13910

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Fix Civil3D hostname to fix psuedo warning for package users

Reviewers

@reddyashish @QilongTang

@zeusongit
Fix Civil3D hostname to fix psuedo warning for package users (DynamoD…
b459b96 
…S#13910)

* add cache

* add new host name check

* Update PackageManagerExtension.cs

* Update PackageManagerExtension.cs

* Update PackageManagerExtension.cs

* Update PackageManagerExtension.cs

* Update PackageManagerExtension.cs
@QilongTang QilongTang merged commit e6f6cd6 into DynamoDS:RC2.18.0_master Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

@reddyashish reddyashish reddyashish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zeusongit @QilongTang @reddyashish