Skip to content

DYN-5782-PrePopulate-CustomColorPicker #13903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 2 commits into from
Apr 18, 2023
Merged

DYN-5782-PrePopulate-CustomColorPicker #13903

QilongTang merged 2 commits into from
Apr 18, 2023

Conversation

@RobertGlobant20
Copy link
Contributor

@RobertGlobant20 RobertGlobant20 commented Apr 14, 2023

Purpose

This fix will be pre-populating the custom colors in CustomColorPicker with the colors added in the Preferences->GroupStyles section (just for custom Styles). This fix is not applicable for the Color Palette node.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Pre-populating the custom colors in CustomColorPicker with the colors added in the Preferences->GroupStyles section.

Reviewers

@QilongTang

FYIs

@RobertGlobant20
DYN-5782-PrePopulate-CustomColorPicker
9994938 
This fix will be pre-populating the custom colors in CustomColorPicker with the colors added in the Preferences->GroupStyles section (just for custom Styles).
This fix is not applicable for the Color Palette node.
@RobertGlobant20
Copy link
Contributor Author

RobertGlobant20 commented Apr 14, 2023

GIF showing the behavior of the CustomColorPicker.
PreLoadedCustomColorPickerColors

@QilongTang
Copy link
Contributor

QilongTang commented Apr 14, 2023

Hi @RobertGlobant20 This does not apply to color picker node because there is no access to Preferences Panel?

@QilongTang QilongTang added this to the 2.18.0 milestone Apr 14, 2023
@RobertGlobant20
Copy link
Contributor Author

RobertGlobant20 commented Apr 14, 2023

Hi @RobertGlobant20 This does not apply to color picker node because there is no access to Preferences Panel?

@QilongTang well If you are referring to the Color Palette node, I think is more logical to add it in the color picker that is used in the GroupStyles section (due that is reading colors from the custom Group Styles).
It can also be applied to Color Palette node I just need to check if we have a way to access preferencesSettings instance, please let me know if I should add this functionality (by the way I've asked that question in the Jira task yesterday).

@QilongTang
Copy link
Contributor

QilongTang commented Apr 14, 2023

Hi @RobertGlobant20 This does not apply to color picker node because there is no access to Preferences Panel?

@QilongTang well If you are referring to the Color Palette node, I think is more logical to add it in the color picker that is used in the GroupStyles section (due that is reading colors from the custom Group Styles). It can also be applied to Color Palette node I just need to check if we have a way to access preferencesSettings instance, please let me know if I should add this functionality (by the way I've asked that question in the Jira task yesterday).

Understood, I think both cases are what customer asked, please give it a check. Thanks!

@RobertGlobant20
DYN-5782-PrePopulate-CustomColorPicker
93d356e 
This fix will be pre-populating the custom colors in CustomColorPicker (when opened from the Color Palette node) with the colors added in the Preferences->GroupStyles section.
Also I've added a unit test that will be validating that the custom colors list used by ColorPicker is populated correctly with the color loaded from Group Styles
@RobertGlobant20
Copy link
Contributor Author

RobertGlobant20 commented Apr 17, 2023

Hi @RobertGlobant20 This does not apply to color picker node because there is no access to Preferences Panel?

@QilongTang well If you are referring to the Color Palette node, I think is more logical to add it in the color picker that is used in the GroupStyles section (due that is reading colors from the custom Group Styles). It can also be applied to Color Palette node I just need to check if we have a way to access preferencesSettings instance, please let me know if I should add this functionality (by the way I've asked that question in the Jira task yesterday).

Understood, I think both cases are what customer asked, please give it a check. Thanks!

@QilongTang functionality added for the Color Palette node and I've added a unit test. Thanks
see the next commit:
93d356e

@QilongTang QilongTang merged commit 66bf680 into DynamoDS:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.18.0

Development

Successfully merging this pull request may close these issues.

2 participants

@RobertGlobant20 @QilongTang