Skip to content

Conversation

@zeusongit
Copy link
Contributor

Purpose

Fix preference margin

Screenshot 2023-04-12 at 8 05 50 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Reviewers

@reddyashish

@QilongTang QilongTang added this to the 2.18.0 milestone Apr 13, 2023
@QilongTang
Copy link
Contributor

QilongTang commented Apr 13, 2023

There is a reported regression but does not seem related to this PR:
WpfVisualizationTests.CustomNodeNotInWorkspaceTests.InsideCustomNode_NotPlacedInHomeWorkspace_NoGeometry

@RobertGlobant20 Maybe the same case for your PR as well.

@QilongTang QilongTang merged commit ee1473d into DynamoDS:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants