Skip to content

Cp 13834 13859 #13862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 2 commits into from
Mar 31, 2023
Merged

Cp 13834 13859 #13862

QilongTang merged 2 commits into from
Mar 31, 2023

Conversation

@sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Mar 31, 2023 •
edited
Loading

Purpose

Cherry picking to RC2.17.2_master:
#13834 and #13859 from master.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Reviewers

@spodo99

FYIs

spodo99 added 2 commits March 31, 2023 10:14
@spodo99 @sm6srw
ALSO-5603 Add parameter hiding autocomplete options from the UI (Dyna…
f81b1df 
…moDS#13834)

* ALSO-5603 Add parameter hiding autocomplete options from the UI

* ALSO-5603 Use IPreferences for hide autocomplete option

This needs to avoid breaking compatibility

* ALSO-5603 Add hide autocomplete option to the settings

* ALSO-5603 Fix unit test
@spodo99 @sm6srw
ALSO-5603 Hide missing ML complete controls if hiding option is set (D…
f3f1164 
…ynamoDS#13859)
@sm6srw sm6srw requested a review from QilongTang March 31, 2023 14:27
@QilongTang QilongTang merged commit ac1ae39 into DynamoDS:RC2.17.2_master Mar 31, 2023
@QilongTang
Copy link
Contributor

QilongTang commented Mar 31, 2023

Thank you @sm6srw I think there are some other version infos in the branch that needs to be updated. I already modified the tt file but there should be other places needed. Just FYI

@sm6srw
Copy link
Contributor Author

sm6srw commented Mar 31, 2023 •
edited
Loading

@QilongTang Thanks for the heads up. I will walk through the checklist.

@sm6srw sm6srw deleted the CP_13834_13859 branch March 31, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sm6srw @QilongTang @spodo99