Skip to content

update libg #13660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aparajit-pratap merged 6 commits into from
Jan 10, 2023
Merged

update libg #13660

aparajit-pratap merged 6 commits into from
Jan 10, 2023

Conversation

@aparajit-pratap
Copy link
Contributor

@aparajit-pratap aparajit-pratap commented Jan 5, 2023 •
edited
Loading

Purpose

Update LibG. This drop contains:

  • New ToNurbsSurface node with added option to unlimit the input surface before converting it to NURBS.
  • Clear FPEs before making calls to SMI_MAKE_POLYCURVE due to ASM bug
  • Update Curve.ByBlendBetweenCurves node docs

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

New ToNurbsSurface node with added option to unlimit the input surface before converting it to NURBS.
Clear floating point exceptions before making calls to create PolyCurves due to existing bug
Update Curve.ByBlendBetweenCurves node docs

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@aparajit-pratap
Copy link
Contributor Author

aparajit-pratap commented Jan 5, 2023

@mjkkirschner one unrelated test is failing, looks like it's another one of those flaky ones.

@mjkkirschner
Copy link
Member

mjkkirschner commented Jan 5, 2023

@aparajit-pratap what about the .net 6 build? @pinzart90 should that pass now?

@pinzart90
Copy link
Contributor

pinzart90 commented Jan 6, 2023 •
edited
Loading

@aparajit-pratap what about the .net 6 build? @pinzart90 should that pass now?

error NU1605:  DSCoreNodes -> DynamoCore -> DynamoVisualProgramming.LibG_229_0_0 (>= 2.16.0.3686)  [D:\a\Dynamo\Dynamo\Dynamo\src\DynamoCore.net6.sln]
D:\a\Dynamo\Dynamo\Dynamo\src\Libraries\CoreNodes\CoreNodes.csproj : error NU1605:  DSCoreNodes -> DynamoVisualProgramming.LibG_229_0_0 (>= 2.16.0.3357)

I think I duplicated a libg reference in coreNoneds.csproj. Libg pkg references should be common between dotnet frameworks. I will submit the fix to this PR

@aparajit-pratap aparajit-pratap merged commit f8e1f27 into DynamoDS:master Jan 10, 2023
@aparajit-pratap aparajit-pratap deleted the updateLibg branch January 10, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjkkirschner mjkkirschner Awaiting requested review from mjkkirschner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aparajit-pratap @mjkkirschner @pinzart90 @pinzart