Skip to content

Cherry pick 2.17: Don't throw if a package has dlls but no node libraries. #13626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sm6srw merged 1 commit into from
Dec 9, 2022
Merged

Cherry pick 2.17: Don't throw if a package has dlls but no node libraries. #13626

sm6srw merged 1 commit into from
Dec 9, 2022

Conversation

@sm6srw
Copy link
Contributor

@sm6srw sm6srw commented Dec 9, 2022 •
edited
Loading

Purpose

  • Cherry pick from master.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

Fixes an issue where a notification is shown if a package has no node libraries in a protected location

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@sm6srw sm6srw added the WIP label Dec 9, 2022
@sm6srw sm6srw removed the WIP label Dec 9, 2022
@sm6srw sm6srw merged commit 940ce05 into DynamoDS:RC2.17.0_master Dec 9, 2022
@sm6srw sm6srw deleted the package_load_fix_2.17 branch December 9, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjkkirschner mjkkirschner mjkkirschner approved these changes

@BogdanZavu BogdanZavu Awaiting requested review from BogdanZavu

@QilongTang QilongTang Awaiting requested review from QilongTang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sm6srw @mjkkirschner