Skip to content

Conversation

@pinzart90
Copy link
Contributor

Purpose

Cherry pick icons
#13528

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

* update Solid.Repair and Surface.Repair icons

* update

Co-authored-by: pinzart <tiberiu.pinzariu@autodesk.com>
Copy link
Contributor

@aparajit-pratap aparajit-pratap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pinzart90 we haven't been saving icon images to Dynamo\src\Libraries\GeometryUIWpf\Resources, only to Dynamo\src\Resources\ProtoGeometry.

@pinzart90
Copy link
Contributor Author

@pinzart90 we haven't been saving icon images to Dynamo\src\Libraries\GeometryUIWpf\Resources, only to Dynamo\src\Resources\ProtoGeometry.

Ugh..I don't know how those got there. I will remove them

@pinzart90 pinzart90 merged commit 2422117 into RC2.17.0_master Nov 21, 2022
@pinzart90 pinzart90 deleted the cherry_icons branch November 21, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants