Skip to content

Dyn 4837 group styles default font size #13447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
QilongTang merged 15 commits into from
Nov 2, 2022
Merged

Dyn 4837 group styles default font size #13447

QilongTang merged 15 commits into from
Nov 2, 2022

Conversation

@jesusalvino
Copy link
Contributor

@jesusalvino jesusalvino commented Oct 31, 2022 •
edited
Loading

Purpose

Implemente the improvement https://jira.autodesk.com/browse/DYN-4837

(FILL ME IN) This section describes why this PR is here. Usually it would include a reference
to the tracking task that it is part or all of the solution for.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@RobertGlobant20 @filipeotero

@jesusalvino
Copy link
Contributor Author

jesusalvino commented Oct 31, 2022

groupstyle

@QilongTang
Copy link
Contributor

QilongTang commented Oct 31, 2022

Changes looks good but default font size should be 36 instead of 14? Currently, when creating group, the default font size is 36

@QilongTang
Copy link
Contributor

QilongTang commented Nov 1, 2022

Can you add what preferences setting would looks like now and also please add/update unit tests

@QilongTang QilongTang added this to the 2.17.0 milestone Nov 1, 2022
@jesusalvino
Copy link
Contributor Author

jesusalvino commented Nov 2, 2022 •
edited
Loading

Can you add what preferences setting would looks like now and also please add/update unit tests

Done.
imagen

@QilongTang
Copy link
Contributor

QilongTang commented Nov 2, 2022

passed at https://master-15.jenkins.autodesk.com/view/DYN/job/DYN-DevCI_Self_Service/1104/

@QilongTang QilongTang merged commit 5ef188a into DynamoDS:master Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QilongTang QilongTang QilongTang approved these changes

@reddyashish reddyashish reddyashish approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.17.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jesusalvino @QilongTang @reddyashish